I can't believe nobody has said "Apocalypse Now" yet. One of the very best movies ever, so definitely one of the best war movies ever. Granted, it's not about heroism or glorification of warfare, so perhaps that's the reason it didn't come to mind.

Also, "The Eagle Has Landed" and "Battle of the River Plate".